Re: [PATCH] char: agp: fix OOM and buffer overflow

From: Vasiliy Kulikov
Date: Thu Apr 14 2011 - 13:07:40 EST


> -       if ((atomic_read(&bridge->current_memory_agp) + page_count) > bridge->max_memory_agp)
> +       cur_memory = atomic_read(&bridge->current_memory_agp);
> +       if ((cur_memory + page_count > bridge->max_memory_agp) ||
> +           (cur_memory + page_count < page_count))
I should have said that current_memory_agp is already protected by
agp_fe.agp_mutex, so the patch doesn't break atomic operation
(otherwise there is also a race between the check and use of
current_memory_agp).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/