Re: [PATCH 2/3] x86, MCE: Drop default decoding notifier

From: Borislav Petkov
Date: Wed Apr 13 2011 - 10:39:42 EST


On Wed, Apr 13, 2011 at 10:32:35AM -0400, Prarit Bhargava wrote:
>
> >> .. right ... but we would still see nonsensical messages before the
> >> panic, which will confuse the end user. IMO, dump the messages unless
> >> it's UC. And we shouldn't print out the human readable message at all.
> >>
> > I'd still leave the "mcelog ... " line though as a hint.
> >
> >
>
> :)
>
> There are no messages -- that's part of the problem. We're asking a
> user to do something for a message that doesn't exist ...

Yes and no - in the UC case you get all the MCA registers dumped in
print_mce() - and those you want to decode. In the CE case, we won't be
issuing any with the default notifier removed. I just sent you a -v2, I
think it should do what we want.

Or am I missing something...?

Thanks.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/