Re: [PATCH 3/4]percpu_counter: fix code for 32bit systems

From: Eric Dumazet
Date: Tue Apr 12 2011 - 23:53:53 EST


Le mercredi 13 avril 2011 Ã 11:03 +0800, Shaohua Li a Ãcrit :
> I can do this, but please give a reason. If network code is the only
> place requiring disable irq, why not network code do it?
>

Lot of percpu_counter users dont use full s64 range, but "unsigned long"
or "unsigned int". Adding a lock on 32bit arches to get the s64, then
truncate it is not needed.

This discussion reminds me an old one ;)

http://kerneltrap.org/mailarchive/linux-ext4/2008/12/12/4401894



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/