Re: [PATCH]: mce: don't print "human readable" message for corrected errors

From: Russ Anderson
Date: Tue Apr 12 2011 - 23:00:40 EST


On Tue, Apr 12, 2011 at 10:28:54PM +0200, Borislav Petkov wrote:
>
> Yeah, there's the TAINT thing too, good point Tony. Well, we definitely
> don't want to get tainted for correctable errors - they're too "normal"
> to do so, IMHO.

I agreed.

> I'm thinking remove the TAINT for CEs and don't call the default
> notifier if it is the only notifier call registered. Maybe something like
>
> if (num_notifiers(&x86_mce_decoder_chain) > 1)
> atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, &m);
>
> or since the notifiers are priority sorted, don't call notifiers with -1
> prio.
>
> Or something to that effect.

What is the point of having a default notifier if it doesn't get called?

Any consideration of adding thresholding (ie only log the first X number
of corrected errors) as is done on IA64? (see arch/ia64/kernel/mca.c)

Thanks,
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@xxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/