Re: [PATCH v4 1/2] Use "request_muxed_region" in it87 watchdog drivers

[Natarajan Gurumoorthy]

Alan,
      I looked at your code in kernel/resource.c and I agree the while
is not needed. I guess every time it comes back from "schedule" your
code loops back to reserve the region. I will test the code without
the while and make the needed change.

Regards
Nat

On Tue, Apr 12, 2011 at 4:41 AM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
>> +     while (!request_muxed_region(REG, 2, NAME))
>> +             continue;
>> +
>
> This shouldn't need the loop ? - is it only working with the loop
> present ?
>
>
> Otherwise this looks good - I'd just like to understand if the loop was
> needed (indicating a bug has crept into the muxed alloc code somewhere
> perhaps) or not
>
> Alan
>



-- 
Regards
Nat Gurumoorthy AB6SJ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/