Re: [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c

[Ingo Molnar]

* Florian Mickler <florian@xxxxxxxxxxx> wrote:

> In order to get rid of the ugly CONFIG_ACPI ifdef, we move
> the function acpi_get_override_irq into acpi.c and add a new
> helper function ioapic_get_irq to io_apic.c.
> 
> Signed-off-by: Florian Mickler <florian@xxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Cc: kurup_avinash@xxxxxxxxx
> Cc: maciej.rutecki@xxxxxxxxx
> Cc: rjw@xxxxxxx
> Cc: sedat.dilek@xxxxxxxxx
> LKML-Reference: <1301558489-4198-1-git-send-email-florian@xxxxxxxxxxx>
> ---
> 
> Hi Ingo,
> 
> Instead of exporting find_irq_entry, irq_trigger and irq_polarity, I added a 
> new helper function 'ioapic_get_irq(..)' and exported that. 
> 
> Also I did it as a seperate commit, since it is more of a cleanup and the other 
> commit is already tested... hope this is ok. 

Yeah, looks good in principle.

Mind porting to the latest x86 devel tree and resend the patch? I tried to 
apply your patch but there's a conflict. You can find the tree at:

  http://people.redhat.com/mingo/tip.git/README

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/