Re: [RFC] block integrity: Fix write after checksum calculation problem

From: Chris Mason
Date: Mon Apr 11 2011 - 14:40:40 EST


Excerpts from Christoph Hellwig's message of 2011-04-11 14:25:41 -0400:
> On Mon, Apr 11, 2011 at 01:41:16PM -0400, Chris Mason wrote:
> > Actually this isn't a nit. Keeping the page locked closes an important
> > hole where it can become writeback again. It might fix the last
> > remaining problem.
>
> Note that the generic block_page_mkwrite atually does that. But only
> xfs and nilfs2 actually make use of it.
>

Btrfs does return VM_FAULT_LOCKED though. I had forgotten to look for
this in the ext4 page_mkwrite call.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/