Re: [PATCH 1/2] break out page allocation warning code

[Michal Nazarewicz]

> > On Apr 8, 2011 10:23 PM, "Dave Hansen" <dave@xxxxxxxxxxxxxxxxxx> wrote:
> > > +       if (fmt) {
> > > +               printk(KERN_WARNING);
> > > +               va_start(args, fmt);
> > > +               r = vprintk(fmt, args);
> > > +               va_end(args);
> > > +       }

> On Fri, 2011-04-08 at 22:54 +0200, MichaÅ Nazarewicz wrote:
> > Could we make the "printk(KERN_WARNING);" go away and require caller
> > to specify level?

On Fri, 08 Apr 2011 23:02:02 +0200, Dave Hansen wrote:
> The core problem is this: I want two lines of output: one for the
> order/mode gunk, and one for the user-specified message.
>
> If we have the user pass in a string for the printk() level, we're stuck
> doing what I have here.  If we have them _prepend_ it to the "fmt"
> string, then it's harder to figure out below.  I guess we could fish in
> the string for it.

This is a bit unfortunate, but that's what I was worried anyway.  I guess
creating a macro which automatically prepends format  with KERN_WARNING
would solve the issue but that's probably not the most elegant solution.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/