Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

From: Gábor Stefanik
Date: Fri Apr 08 2011 - 16:00:48 EST


On Fri, Apr 8, 2011 at 9:45 PM, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
> Cc: Michael BÃsch <mb@xxxxxxxxx>
> Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: George Kashperko <george@xxxxxxxxxxx>
> Cc: Arend van Spriel <arend@xxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> Cc: Russell King <rmk@xxxxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linuxdriverproject <devel@xxxxxxxxxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
> Signed-off-by: RafaÅ MiÅecki <zajec5@xxxxxxxxx>
> ---
> This is second try for introducing new bus driver.
> V2: Rename to axi
> Â ÂUse DEFINE_PCI_DEVICE_TABLE in bridge
> Â ÂMake use of pr_fmt and pr_*
> Â ÂStore core class
> Â ÂRename bridge to not b43 specific
> Â ÂReplace magic 0x1000 with BCMAI_CORE_SIZE
> Â ÂRemove some old "ssb" names and defines
> Â ÂMove BCMAI_ADDR_BASE def
> Â ÂAdd drvdata field
> TODO:
> - Interrupts
> - Reloading driver
> ---
> Âdrivers/Kconfig              |  Â2 +
> Âdrivers/Makefile             Â|  Â1 +
> Âdrivers/axi/Kconfig            |  30 +++
> Âdrivers/axi/Makefile           Â|  Â5 +
> Âdrivers/axi/axi_pci_bridge.c       Â|  33 +++
> Âdrivers/axi/axi_private.h         |  45 ++++
> Âdrivers/axi/core.c            Â|  52 ++++
> Âdrivers/axi/driver_chipcommon.c      |  87 +++++++
> Âdrivers/axi/driver_chipcommon_pmu.c    | Â134 ++++++++++
> Âdrivers/axi/driver_pci.c         Â| Â191 ++++++++++++++
> Âdrivers/axi/host_pci.c          Â| Â177 +++++++++++++
> Âdrivers/axi/main.c            Â| Â256 +++++++++++++++++++
> Âdrivers/axi/scan.c            Â| Â393 +++++++++++++++++++++++++++++
> Âdrivers/axi/scan.h            Â|  56 ++++
> Âinclude/linux/axi/axi.h          | Â221 ++++++++++++++++
> Âinclude/linux/axi/axi_driver_chipcommon.h | Â308 ++++++++++++++++++++++
> Âinclude/linux/axi/axi_driver_pci.h    Â|  85 +++++++
> Âinclude/linux/axi/axi_regs.h       Â|  34 +++
> Âinclude/linux/mod_devicetable.h      |  17 ++
> Âscripts/mod/file2alias.c         Â|  21 ++
> Â20 files changed, 2148 insertions(+), 0 deletions(-)
> Âcreate mode 100644 drivers/axi/Kconfig
> Âcreate mode 100644 drivers/axi/Makefile
> Âcreate mode 100644 drivers/axi/axi_pci_bridge.c
> Âcreate mode 100644 drivers/axi/axi_private.h
> Âcreate mode 100644 drivers/axi/core.c
> Âcreate mode 100644 drivers/axi/driver_chipcommon.c
> Âcreate mode 100644 drivers/axi/driver_chipcommon_pmu.c
> Âcreate mode 100644 drivers/axi/driver_pci.c
> Âcreate mode 100644 drivers/axi/host_pci.c
> Âcreate mode 100644 drivers/axi/main.c
> Âcreate mode 100644 drivers/axi/scan.c
> Âcreate mode 100644 drivers/axi/scan.h
> Âcreate mode 100644 include/linux/axi/axi.h
> Âcreate mode 100644 include/linux/axi/axi_driver_chipcommon.h
> Âcreate mode 100644 include/linux/axi/axi_driver_pci.h
> Âcreate mode 100644 include/linux/axi/axi_regs.h
>
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 177c7d1..1244e8c 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -68,6 +68,8 @@ source "drivers/watchdog/Kconfig"
>
> Âsource "drivers/ssb/Kconfig"
>
> +source "drivers/axi/Kconfig"
> +
> Âsource "drivers/mfd/Kconfig"
>
> Âsource "drivers/regulator/Kconfig"
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 3f135b6..6e1979b 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -110,6 +110,7 @@ obj-$(CONFIG_HID) Â Â Â Â Â += hid/
> Âobj-$(CONFIG_PPC_PS3) Â Â Â Â Â+= ps3/
> Âobj-$(CONFIG_OF) Â Â Â Â Â Â Â += of/
> Âobj-$(CONFIG_SSB) Â Â Â Â Â Â Â+= ssb/
> +obj-$(CONFIG_AXI) Â Â Â Â Â Â Â+= axi/
> Âobj-$(CONFIG_VHOST_NET) Â Â Â Â Â Â Â Â+= vhost/
> Âobj-$(CONFIG_VLYNQ) Â Â Â Â Â Â+= vlynq/
> Âobj-$(CONFIG_STAGING) Â Â Â Â Â+= staging/
> diff --git a/drivers/axi/Kconfig b/drivers/axi/Kconfig
> new file mode 100644
> index 0000000..f4f58f5
> --- /dev/null
> +++ b/drivers/axi/Kconfig
> @@ -0,0 +1,30 @@
> +config AXI_POSSIBLE
> + Â Â Â bool
> + Â Â Â depends on HAS_IOMEM && HAS_DMA
> + Â Â Â default y
> +
> +menu "AMBA AXI"
> + Â Â Â depends on AXI_POSSIBLE
> +
> +config AXI
> + Â Â Â tristate "AXI support"
> + Â Â Â depends on AXI_POSSIBLE
> +
> +config AXI_HOST_PCI_POSSIBLE
> + Â Â Â bool
> + Â Â Â depends on AXI && PCI = y
> + Â Â Â default y
> +
> +config AXI_HOST_PCI
> + Â Â Â bool "Support for AI on PCI-host bus"

Shouldn't this say AXI?

> + Â Â Â depends on AXI_HOST_PCI_POSSIBLE
> +
> +config AXI_DEBUG
> + Â Â Â bool "AXI debugging"
> + Â Â Â depends on AXI
> + Â Â Â help
> + Â Â Â Â This turns on additional debugging messages.
> +
> + Â Â Â Â If unsure, say N
> +
> +endmenu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/