Re: [Regression] USB tethering does not work anymore in 2.6.29-rc2(rndis_host, does not receive DHCP offer anymore)

From: Gottfried Haider
Date: Thu Apr 07 2011 - 23:31:45 EST


>   I found the new added mask code 'FLAG_POINTTOPOINT' overlapped
> 'FLAG_MULTI_PACKET' in    include/linux/usb/usbnet.h, this maybe
> caused logic issue in rx_process(). I create a patch for this, but
> have no such a device to test it, could you have a try? thanks.

Will try the patch tomorrow morning and report back.

Gottfried


> [PATCH]    Clean up mask code overlaps in driver_info of usbnet
>
> Signed-off-by:  Huajun Li <huajun.li.lee@xxxxxxxxx>
> ---
>  include/linux/usb/usbnet.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
> index 3c7329b..0e18550 100644
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -103,8 +103,8 @@ struct driver_info {
>  * Indicates to usbnet, that USB driver accumulates multiple IP packets.
>  * Affects statistic (counters) and short packet handling.
>  */
> -#define FLAG_MULTI_PACKET      0x1000
> -#define FLAG_RX_ASSEMBLE       0x2000  /* rx packets may span >1 frames */
> +#define FLAG_MULTI_PACKET      0x2000
> +#define FLAG_RX_ASSEMBLE       0x4000  /* rx packets may span >1 frames */
>
>        /* init device ... can sleep, or cause probe() failure */
>        int     (*bind)(struct usbnet *, struct usb_interface *);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/