Re: tip: New "Link:" tag to replace "LKML-Reference:"

From: Peter Zijlstra
Date: Thu Apr 07 2011 - 11:04:11 EST


On Thu, 2011-04-07 at 07:56 -0700, H. Peter Anvin wrote:
> On 04/07/2011 07:54 AM, Peter Zijlstra wrote:
> >
> > Can't we use a prepare-commit-msg or commit-msg hook to re-write the
> > commit message to include a Link tag when one is missing, using
> > something like:
> >
> > Link: http://lkml.kernel.org/r/tip-$SHA@xxxxxxxxxxxxxx
> >
> > And have the post-commit hook that sends the messages recognize this
> > form and send the message using the correct msgid.
> >
> > That way the commit includes a correct and clickable link, doesn't
> > require magic knowledge and doesn't need the committer to do extra work.
> >
>
> Think about it... hint: the SHA1 is a cryptographically secure signature
> of the commit object.

D'0h ok.. but the scheme would work with any generated msgid, all we
need is to generate one for commits that lack a Link tag and insert it
using the prepare-commit-msg/commit-msg hooks and for the post-commit
hook to recognize it and use that actual msgid.

The only thing to avoid is msgid collision, but given that MUAs already
have this problem all we need to do is borrow some of their logic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/