Re: [PATCH] ARM: Allow for kernel command line concatenation

From: Uwe Kleine-König
Date: Thu Apr 07 2011 - 06:59:31 EST


On Thu, Apr 07, 2011 at 12:35:01PM +0200, Paul Bolle wrote:
> On Thu, 2011-04-07 at 10:17 +0200, oskar.andero@xxxxxxxxxxxxxxxx wrote:
> > +config CMDLINE_EXTEND
> > + bool "Extend bootloader kernel arguments"
> > + depends on CMDLINE != ""
> > + help
> > + The default kernel command string will be concatenated with the
> > + arguments provided by the boot loader.
>
> This suggests the parameters provided by the boot loader will override
> corresponding parameters of the default kernel command string. Is that
> correct (for all possible parameters)?
>
> Either way, shouldn't it be documented, perhaps in this help text, what
> will happen if a parameter of the default kernel command string and a
> parameter provided by the boot loader somehow conflict?
Then you will end up with both parameters I guess. What happens depends
on the parameter in question I guess. IMHO the description is fine.
But I wonder if the new mechanism is useful in the end.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/