Re: [PATCH 01/24] sysctl: net: call unregister_net_sysctl_table where needed

From: Lucian Adrian Grijincu
Date: Wed Apr 06 2011 - 16:05:20 EST


On Wed, Apr 6, 2011 at 9:52 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> Oops, hmmm... ÂCan this actually cause any real problems currently?
>
> If so I'd like to toss this specific patch into net-2.6


Nope:

void unregister_net_sysctl_table(struct ctl_table_header *header)
{
unregister_sysctl_table(header);
}
EXPORT_SYMBOL_GPL(unregister_net_sysctl_table);

But I thought that in the future, if something special needs to be
done for unregister_net_sysctl_table, it would be better to have these
consistent. I'll do a check on all the tree to see if there are other
cases.

Another approach would be to remove unregister_net_sysctl_table, as it
does nothing different of unregister_sysctl_table and let our future
selves deal with the problem.

Can you tell me what you'd like?

--
Â.
..: Lucian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/