Re: [RFC PATCH 6/7] basic_mmio_gpio: support differentinput/output registers

[Anton Vorontsov]

On Wed, Apr 06, 2011 at 12:11:02PM +0100, Jamie Iles wrote:
> Some controllers have separate input and output registers.  For these
> controllers, allow a register named "in" to be used for reading the
> value of a GPIO pin.
> 
> Signed-off-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
> Cc: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> ---
[...]
> @@ -316,6 +340,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
>  	if (!bgc->reg_dat)
>  		return -ENOMEM;
>  
> +	spin_lock_init(&bgc->lock);
> +

Hm. This looks like a stray change, now bgpio_probe() calls spin_lock_init()
twice.

Other than that, the patch seems to be OK.

Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/