Re: [PATCH] sr: Ensure disk is revalidated when media changes

[Amit Shah]

On (Wed) 06 Apr 2011 [03:06:20], Tejun Heo wrote:
> On Tue, Apr 05, 2011 at 12:21:30PM +0530, Amit Shah wrote:
> > > But I don't think this is the correct place to do it.  The problem
> > > happens because block layer consumes the event but doesn't remember it
> > > when the time for revalidation comes.  It should be done by block
> > > layer, not sr.  Hmmm... looking at the code, the new disk event code
> > > should handle this correctly.  Was 2.6.38 showing the problem too?
> > 
> > Yes, 2.6.38 shows the same problem.  I went back to ancient kernels
> > (2.6.31 on Fedora 11-alpha) which had the previous media_changed
> > infrastructure and those places too show the same behaviour (with the
> > TEST_UNIT_READY way of detecting media changes).
> 
> Can you please the patch attached in the following bz and see whether
> it makes any difference?
> 
>  https://bugzilla.kernel.org/show_bug.cgi?id=13029

Yes, this works.

You can add Tested-by: Amit Shah <amit.shah@xxxxxxxxxx>

Thanks!

		Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/