Re: [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver

[Guenter Roeck]

Hi Jean,

On Wed, Apr 06, 2011 at 03:23:58AM -0400, Jean Delvare wrote:
> Hi Andrew,
> 
[ ... ]
> > +
> > +/* Register Addresses */
> > +#define LOCAL_TEMP_RD			0x00
> > +#define EXT_HI_TEMP_RD			0x01
> > +#define EXT_LO_TEMP_RD			0x10
> > +#define STATUS_RD			0x02
> > +#define CONFIG_RD			0x03
> > +
> > +#define CONFIG_WR			0x09
> > +#define CONV_RATE_WR			0x0A
> > +#define LOCAL_TEMP_HI_LIMIT_WR		0x0B
> > +#define EXT_TEMP_HI_LIMIT_HI_BYTE	0x0D
> > +#define OFFSET_WR			0x11
> > +#define EXT_THERM_LIMIT_WR		0x19
> > +#define LOCAL_THERM_LIMIT_WR		0x20
> > +#define THERM_HYSTERESIS_WR		0x21
> 
> These register definitions look very familiar to me. Have you looked at
> the lm90 driver to check has difficult it would be to add support for
> the NCT1008? I bet it will only take a few lines of code.
> 
After I spent a couple of hours reviewing the driver, I noticed that the chip is functionally
identical to ADT7461A (the only difference is the package; even the chip ID is the same),
and the ADT7461A is in turn functionally identical to ADT7461. Sigh :(.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/