Re: [patch 11/15] sched: hierarchical task accounting forSCHED_OTHER

[Peter Zijlstra]

On Tue, 2011-03-22 at 20:03 -0700, Paul Turner wrote:
> With task entities participating in throttled sub-trees it is possible for
> task activation/de-activation to not lead to root visible changes to
> rq->nr_running.  This in turn leads to incorrect idle and weight-per-task load
> balance decisions.
> 
> To allow correct accounting we move responsibility for updating rq->nr_running
> to the respective sched::classes.  In the fair-group case this update is
> hierarchical, tracking the number of active tasks rooted at each group entity.
> 
> This also allows us to fix a small buglet in pick_next_task() when group
> scheduling is enabled.
> 
> Note: technically this issue also exists with the existing sched_rt
> throttling; however due to the nearly complete provisioning of system
> resources for rt scheduling this is much less common by default.

Shouldn't this patch live at the start of the series?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/