Re: [PATCH 04/12] Staging: hv: Rename vmbus_driver_context structure

[Greg KH]

On Tue, Mar 15, 2011 at 03:03:35PM -0700, K. Y. Srinivasan wrote:
> Now that struct vmbus_driver_context is properly
> cleaned up, rename this structure appropriately and
> cleanup the code.
> 
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Signed-off-by: Mike Sterling <mike.sterling@xxxxxxxxxxxxx>
> Signed-off-by: Abhishek Kane <v-abkane@xxxxxxxxxxxxx>
> Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx>
> ---
>  drivers/staging/hv/vmbus_drv.c |   32 +++++++++++++++-----------------
>  1 files changed, 15 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
> index 239b91c..f292b03 100644
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -41,7 +41,7 @@
>  struct pci_dev *hv_pci_dev;
>  
>  /* Main vmbus driver data structure */
> -struct vmbus_driver_context {
> +struct hv_bus {
>  	struct bus_type bus;
>  	struct tasklet_struct msg_dpc;
>  	struct tasklet_struct event_dpc;
> @@ -99,7 +99,7 @@ static struct device_attribute vmbus_device_attrs[] = {
>  };
>  
>  /* The one and only one */
> -static struct vmbus_driver_context vmbus_drv = {
> +static struct hv_bus  hv_bus = {

2 spaces?


>  	.bus.name =		"vmbus",
>  	.bus.match =		vmbus_match,
>  	.bus.shutdown =		vmbus_shutdown,

Wait, why is a bus_type embedded within another structure?  That
is going to get pulled out later, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/