Re: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr_<level>

[Sedat Dilek]

On Mon, Apr 4, 2011 at 8:10 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2011-04-04 at 20:03 +0200, Sedat Dilek wrote:
>> On Mon, Apr 4, 2011 at 7:06 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> [...]
>> > Â#ifdef CONFIG_THINKPAD_ACPI_DEBUG
>> > Â#define vdbg_printk dbg_printk
>> > Âstatic const char *str_supported(int is_supported);
>> > Â#else
>> > -#define vdbg_printk(a_dbg_level, format, arg...) \
>> > - Â Â Â do { } while (0)
>> > +static inline const char *str_supported(int is_supported) { return ""; }
>> > +#define vdbg_printk(a_dbg_level, format, arg...) Â Â Â \
>> > + Â Â Â no_printk(format, ##arg)
>> > Â#endif
>>
>> Should be...
>> + Â Â Â do { } while (0)
>> ...not...
>> + Â Â Â no_printk(format, ##arg)
>
> I disagree. ÂNo printk serves as a mechanism to verify
> printk arguments when !CONFIG_THINKPAD_ACPI_DEBUG.
>

Oops sorry, now I see you have chosen solution #1 :-).

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/