Re: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr_<level>

[Sedat Dilek]

On Mon, Apr 4, 2011 at 7:06 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Add pr_fmt.
> Removed local TPACPI_<level> #defines, convert to pr_<level>.
> Neaten dbg_<foo> macros.
> Added a few missing newlines to logging messages.
> Added static inline str_supported for !CONFIG_THINKPAD_ACPI_DEBUG vdbg_printk
> defect reported by Sedat Dilek <sedat.dilek@xxxxxxxxxxxxxx>.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> Âdrivers/platform/x86/thinkpad_acpi.c | Â472 ++++++++++++++--------------------
> Â1 files changed, 188 insertions(+), 284 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[...]
> Â#ifdef CONFIG_THINKPAD_ACPI_DEBUG
> Â#define vdbg_printk dbg_printk
> Âstatic const char *str_supported(int is_supported);
> Â#else
> -#define vdbg_printk(a_dbg_level, format, arg...) \
> - Â Â Â do { } while (0)
> +static inline const char *str_supported(int is_supported) { return ""; }
> +#define vdbg_printk(a_dbg_level, format, arg...) Â Â Â \
> + Â Â Â no_printk(format, ##arg)
> Â#endif

Should be...
+       do { } while (0)
...not...
+       no_printk(format, ##arg)

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/