Re: [PATCH] tile,mn10300: add device parameter to dma_cache_sync()

[FUJITA Tomonori]

On Mon, 4 Apr 2011 16:21:47 +0100
James Hogan <james@xxxxxxxxxxxxx> wrote:

> From: James Hogan <james.hogan@xxxxxxxxxx>
> 
> Note: I'm not in a position to compile test this patch, but I don't
> foresee any problems.
> 
> Since v2.6.20 "Pass struct dev pointer to dma_cache_sync()"
> (d3fa72e4556ec1f04e46a0d561d9e785ecaa173d), dma_cache_sync() takes a
> struct dev pointer, but these appear to be missing from the tile and
> mn10300 implementations, so add them.
> 
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> ---
>  arch/mn10300/include/asm/dma-mapping.h |    2 +-
>  arch/tile/include/asm/dma-mapping.h    |    3 ++-
>  arch/tile/kernel/pci-dma.c             |    2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)

Looks fine (I don't even compile it though).

btw, mn10300's dma_cache_sync looks wrong.

DMA-API says:

Do a partial sync of memory that was allocated by
dma_alloc_noncoherent(), starting at virtual address vaddr and
continuing on for size.  Again, you *must* observe the cache line
boundaries when doing this.

looks like mn10300's dma_alloc_noncoherent() returns consistent
memory. So dma_cache_sync should be a null function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/