Re: [PATCH urgent] x86: Save cr4 to mmu_cr4_features at boot time

From: Ingo Molnar
Date: Mon Apr 04 2011 - 12:25:28 EST



* Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote:

> On Mon, 4 Apr 2011, Ingo Molnar wrote:
> >
> > * Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> >
> > > Just to clarify the situation the patch "x86-64: finish cleanup_highmaps()'s
> > > job wrt. _brk_end" was backported to the stable trees [...]
> >
> > There's no commit with such a title upstream - there's not even one that is
> > close. Could you cite the sha1 you refer to?
>
> The commit id upstream is 498343967613183611ac37dccb2846496d954c06

That commit is from the v2.6.30 era:

|
| commit 498343967613183611ac37dccb2846496d954c06
| Author: Jan Beulich <jbeulich@xxxxxxxxxx>
| AuthorDate: Wed May 6 13:06:47 2009 +0100
| Commit: H. Peter Anvin <hpa@xxxxxxxxx>
| CommitDate: Thu May 7 21:51:34 2009 -0700
|
| x86-64: finish cleanup_highmaps()'s job wrt. _brk_end
|

... i.e. the bug is almost 2 years and 8 -stable cycles old!

Peter very consciously did not mark the fix for this commit as -stable
material. It was ineligible for -stable for multiple reasons: it by no means
fixed a 2.6.39 regression and the fix was literally just a few days old.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/