Re: [PATCH 2/2] kbuild: move KALLSYMS_EXTRA_PASS from Kconfig to Makefile

[Valdis . Kletnieks]

On Mon, 04 Apr 2011 15:47:10 +0300, Artem Bityutskiy said:
> On Mon, 2011-04-04 at 08:45 -0400, Valdis.Kletnieks@xxxxxx wrote:
> > On Mon, 04 Apr 2011 13:40:51 +0300, Artem Bityutskiy said:
> >
> > > 3. By default KALLSYMS_EXTRA_PASS is disabled and if kallsyms has issues,
> > >    "make" should print a warning and suggest using KALLSYMS_EXTRA_PASS
> >
> > If the Makefile has enough information to print the warning, why can't it go
> > ahead and do the extra pass itself instead of issuing the warning?
> >
> > (I'm obviously missing something here, as I'm foolishly posting to lkml before
> > caffeine ;)
>
> Good question, I thought to force people to send a bugreport.

When was the last time we actually saw such a bug report?  I'm suspecting that
all the affected people just set the variable and get on with their lives.  So
we should either just make it automatic if that's what people are going to do,
or we rip the entire "EXTRA_PASS' stuff out forcibly and *make* people fix the
actual underlying issue that causes the extra pass to be needed...

Attachment: pgp00000.pgp
Description: PGP signature