Re: [PATCH resend] hid-magicmouse: Increase evdev buffer size

[Chase Douglas]

On 04/01/2011 07:51 PM, Jeffrey Brown wrote:
> I've got another change in the works that fixes this problem more
> systematically.

That would be great :). I still would like to see this patch added so
it's released with the 2.6.39 kernel and backported to earlier stable
releases. I hope that's not a problem.

Thanks,

-- Chase

> On Fri, Apr 1, 2011 at 2:03 PM, Chase Douglas
> <chase.douglas@xxxxxxxxxxxxx> wrote:
>> The evdev buffer isn't big enough when you get many fingers on the
>> device. Bump up the buffer to a reasonable size, matching what other
>> multitouch devices use. Without this change, events may be discarded in
>> the evdev buffer before they are read.
>>
>> Reported-by: Simon Budig <simon@xxxxxxxx>
>> Cc: Henrik Rydberg <rydberg@xxxxxxxxxxx>
>> Cc: Jiri Kosina <jkosina@xxxxxxx>
>> Cc: stable@xxxxxxxxxx
>> Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
>> ---
>> Forgot to Cc the mailing lists on the first send.
>>
>>  drivers/hid/hid-magicmouse.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
>> index 698e645..404dcbc 100644
>> --- a/drivers/hid/hid-magicmouse.c
>> +++ b/drivers/hid/hid-magicmouse.c
>> @@ -418,6 +418,8 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
>>                        input_set_abs_params(input, ABS_MT_POSITION_Y, -2456,
>>                                2565, 4, 0);
>>                }
>> +
>> +               input_set_events_per_packet(input, 60);
>>        }
>>
>>        if (report_undeciphered) {
>> --
>> 1.7.4.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/