Re: [PATCH 2/2] Input: sparse-keymap - report KEY_UNKNOWN for unknown scan codes

From: Seth Forshee
Date: Fri Mar 25 2011 - 09:40:18 EST


On Fri, Mar 25, 2011 at 12:35:54AM -0700, Dmitry Torokhov wrote:
> Hi Seth,
>
> On Wed, Mar 23, 2011 at 04:13:43PM -0500, Seth Forshee wrote:
> >
> > + /* Report an unknown key event as a debugging aid */
> > + unknown_ke.type = KE_KEY;
> > + unknown_ke.code = code;
> > + unknown_ke.keycode = KEY_UNKNOWN;
> > + sparse_keymap_report_entry(dev, &unknown_ke, value, autorelease);
>
> I think it should not depend on autorelease but always automatically
> release KEY_UNKNOWN.
>
> Otherwise I think I'll apply both patches.

Great! Here are the patches with that changed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/