Re: [RFC PATCH] et1011c: Replaced PHY driver by a small dm646x board fixup

[Andy Fleming]

On Wed, Mar 23, 2011 at 5:33 PM, Kyle Moffett <Kyle.D.Moffett@xxxxxxxxxx> wrote:

> -
> -static struct phy_driver et1011c_driver = {
> -       .phy_id         = 0x0282f014,
> -       .name           = "ET1011C",
> -       .phy_id_mask    = 0xfffffff0,
> -       .features       = (PHY_BASIC_FEATURES | SUPPORTED_1000baseT_Full),
> -       .flags          = PHY_POLL,
> -       .config_aneg    = et1011c_config_aneg,
> -       .read_status    = et1011c_read_status,
> -       .driver         = { .owner = THIS_MODULE,},
> -};


Might I suggest that you not eliminate the whole driver?  If you leave
just this part (and the init stuff below it), and convert the
config_aneg and read_status pointers to use the genphy versions, the
kernel will, at least, be able to report what type of PHY it is.  And
maybe one day, someone who is familiar with the inner workings of this
PHY will fill in a more correct driver.

Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/