Re: [PATCH][RFC] Null short-circuit for selinux_cred_free()

[Jesper Juhl]

On Wed, 23 Mar 2011, Tetsuo Handa wrote:

> Jesper Juhl wrote:
> > Let selinux_cred_free accept NULL pointers.
> No need to do so.
> 
> > If we don't do this, then we can crash if someone manages to pass NULL to 
> > cred_free. Seems to me it's better to just do nothing in that case rather 
> > than crash.
> If cred == NULL, put_cred_rcu(NULL) causes the kernel to panic before calling
> LSM hooks.

Good point. Thanks.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/