[PATCH 1/1] cciss: fix lost command issue

From: Mike Miller
Date: Wed Mar 23 2011 - 15:33:49 EST


Patch 1 of 1

cciss: fix lost command problem

From: Bud Brown <bud.brown@xxxxxxxxxx>

Under certain workloads a command may seem to get lost. IOW, the Smart Array
thinks all commands have been completed but we still have commands in our
completion queue. This may lead to system instability, filesystems going
read-only, or even panics depending on the affected filesystem. We add an
extra read to force the write to complete.

Testing shows this extra read avoids the problem.

Signed-off-by: Mike Miller <mike.miller@xxxxxx>

diff -urNp linux-2.6/drivers/block/cciss.h linux-2.6-03212011/drivers/block/cciss.h
--- linux-2.6/drivers/block/cciss.h 2011-03-21 15:41:23.100192400 -0500
+++ linux-2.6-03212011/drivers/block/cciss.h 2011-03-21 15:39:20.472192814 -0500
@@ -222,6 +222,7 @@ static void SA5_submit_command( ctlr_inf
h->ctlr, c->busaddr);
#endif /* CCISS_DEBUG */
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
h->commands_outstanding++;
if ( h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/