Re: [RFC PATCH] mutex: Apply adaptive spinning on mutex_trylock()

From: Tejun Heo
Date: Wed Mar 23 2011 - 11:52:15 EST


On Wed, Mar 23, 2011 at 08:48:01AM -0700, Linus Torvalds wrote:
> On Wed, Mar 23, 2011 at 8:37 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> >
> > Currently, mutex_trylock() doesn't use adaptive spinning.  It tries
> > just once.  I got curious whether using adaptive spinning on
> > mutex_trylock() would be beneficial and it seems so, at least for
> > btrfs anyway.
>
> Hmm. Seems reasonable to me. The patch looks clean, although part of
> that is just the mutex_spin() cleanup that is independent of actually
> using it in trylock.

Oh, I have two split patches. Posted the combined one for comments.

> So no objections from me.

Awesome. Peter, what do you think? Are there some other tests which
can be useful?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/