Re: [PATCH 7/8] job control: Notify the real parent of job controlevents regardless of ptrace

From: Tejun Heo
Date: Wed Mar 23 2011 - 05:25:07 EST


On Wed, Mar 23, 2011 at 10:17:36AM +0100, Tejun Heo wrote:
> Hey, Oleg.
>
> On Tue, Mar 22, 2011 at 08:44:16PM +0100, Oleg Nesterov wrote:
> > On 03/22, Tejun Heo wrote:
> > >
> > > On Mon, Mar 21, 2011 at 06:43:06PM +0100, Oleg Nesterov wrote:
> > > > Hmm... in fact I can't convince myself we really need to look at
> > > > child->group_leader, will recheck... Anyway, this is minor too.
> > >
> > > Care to elaborate?
> >
> > child->real_parent must be equal to child->group_leader->real_parent.
>
> Okay.

Ooh, on a related note, we probably want to change
do_notify_parent_cldstop() too. tsk->group_leader->real_parent is
used as the delivery target when !@for_ptracer. This is the same with
tsk->real_parent and the code has been like this for a long time but
is a bit confusing.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/