Re: [PATCH 1/7] char/mei: PCI device and char driver support.

[Greg KH]

On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > * In the PCI probe function, create a misc character device for
> >   every instance you find behind each device. Remove the global
> >   variables and constants.
> 
> The current code is complex and could be a ton simpler *but* don't
> abuse misc devices when you have one per PCI instance please.

The code specifically says it only supports one device in the system at
a time.  Since it can't do any more than that, why wouldn't it be
correct for a misdevice to be used here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/