Re: [PATCH 4/6 v7] overlay filesystem prototype

[Miklos Szeredi]

On Tue, 22 Mar 2011, Linus Torvalds wrote:
> Just one single C file? Is there no structure to the code at all? No
> separate issues for directory lookup vs file operations, no helper
> libraries vs core ops? No "mount time" vs "runtime" structure to the
> code?
> 
> So 2400 lines isn't all that much, but things have a tendency to grow.
> So when I see one single file that tries to do everything, I go "hmm".
> Normal filesystems tend to have super.c for handling the mount itself,
> and dir.c vs file.c for directory ops vs file ops. Maybe this doesn't
> have a file.c because that's all delegated to the lower filesystems,
> but still.. Just one file?
> 
> Yeah, yeah, we have those horrible drivers that have 10k+ files, and
> there are certainly filesystems with much bigger files, but I'd still
> wish for more structure.  You've got a whole subdirectory of your own.

Sure, good comment.

I'll split this for the actual pull request, if the overall approach
gets an ACK.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/