Re: [PATCH] kvm: fix crash on irqfd deassign

From: Michael S. Tsirkin
Date: Tue Mar 22 2011 - 08:51:18 EST


On Tue, Mar 22, 2011 at 02:37:27PM +0200, Avi Kivity wrote:
> On 03/17/2011 10:53 AM, Michael S. Tsirkin wrote:
> >irqfd in kvm used flush_work incorrectly:
> >it assumed that work scheduled previously can't run
> >after flush_work, but since kvm uses a non-reentrant
> >workqueue (by means of schedule_work)
> >we need flush_work_sync to get that guarantee.
> >
> >Signed-off-by: Michael S. Tsirkin<mst@xxxxxxxxxx>
> >Reported-by: Jean-Philippe Menil<jean-philippe.menil@xxxxxxxxxxxxxx>
> >Tested-by: Jean-Philippe Menil<jean-philippe.menil@xxxxxxxxxxxxxx>
> >---
> >
> >Note: this is needed for kernel 2.6.39 and earlier.
> >
>
> What about kvm.git master?

Sorry about the confusion.

Clarification: this is needed on kvm.git master,
as well as 2.6.39 and earlier.

> --
> error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/