Re: [PATCH 08/13] JFS: use list_move() instead of list_del()/list_add()combination

From: Dave Kleikamp
Date: Mon Mar 21 2011 - 14:49:55 EST


On Tue, Mar 15, 2011 at 5:53 PM, Kirill A. Shutemov
<kirill@xxxxxxxxxxxxx> wrote:
> Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>

Acked-by: Dave Kleikamp <shaggy@xxxxxxxxxx>

> ---
>  fs/jfs/jfs_txnmgr.c |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index 9466957..8cb7b92 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -2979,12 +2979,9 @@ int jfs_sync(void *arg)
>                                 * put back on the anon_list.
>                                 */
>
> -                               /* Take off anon_list */
> -                               list_del(&jfs_ip->anon_inode_list);
> -
> -                               /* Put on anon_list2 */
> -                               list_add(&jfs_ip->anon_inode_list,
> -                                        &TxAnchor.anon_list2);
> +                               /* Move anon_list -> anon_list2 */
> +                               list_move(&jfs_ip->anon_inode_list,
> +                                         &TxAnchor.anon_list2);
>
>                                TXN_UNLOCK();
>                                iput(ip);
> --
> 1.7.4.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/