Re: [PATCH] x86, UV: Fix NMI handler for UV platforms

From: Don Zickus
Date: Mon Mar 21 2011 - 13:53:35 EST


On Mon, Mar 21, 2011 at 07:43:46PM +0300, Cyrill Gorcunov wrote:
> I think Jack might need to setup priority for his notifier, like
>
> static struct notifier_block uv_dump_stack_nmi_nb = {
> .notifier_call = uv_handle_nmi,
> .priority = NMI_LOCAL_HIGH_PRIOR+1,
> };
>
> so it would be called before perf nmi. Don, am I right?

Unless they added register to detect the external nmi button has been
pressed this shouldn't work and in fact if you run 'perf' you will
probably trigger stack traces for all the cpus on your first NMI. That is
what has been explained to me privately.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/