Re: [PATCH 07/20] video: msm: Allow users to request a larger xand y virtual fb

From: Russell King - ARM Linux
Date: Mon Mar 21 2011 - 12:42:40 EST


On Mon, Mar 21, 2011 at 10:10:09AM +0530, Janorkar, Mayuresh wrote:
> > + fix->line_length = var->xres * var->bits_per_pixel / 8;
> Why to divide by 8? Atleast use >>3, bitwise operations that would take
> less cpu cycles)
> As I stated earlier define a new macro for var also.

Modern compilers know about such things. >> 3 vs / 8 (probably) makes no
difference to the generated code with the toolchains we use.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/