Re: [PATCH v3 5/5] hid-multitouch: migrate 3M PCT touch screens tohid-multitouch

From: Henrik Rydberg
Date: Mon Mar 21 2011 - 06:31:55 EST


On Mon, Mar 21, 2011 at 11:13:46AM +0100, Benjamin Tissoires wrote:
> On Mon, Mar 21, 2011 at 10:05, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
> > Hi Benjamin,
> >
> > On Fri, Mar 18, 2011 at 02:27:56PM +0100, Benjamin Tissoires wrote:
> >> This patch merges the hid-3m-pct driver into hid-multitouch.
> >> To keep devices working the same way they used to with hid-3m-pct,
> >> we need to add two signal/noise ratios for width and height.
> >> We also need to work on width/height to send proper
> >> ABS_MT_ORIENTATION flag.
> >>
> >> Importing 3M into hid-multitouch also solved the bug in which
> >> devices handling width and height in their report descriptors
> >> did not show ABS_MT_TOUCH_MAJOR and ABS_MT_TOUCH_MINOR.
> >>
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxx>
> >> Reviewed-by: Stéphane Chatty <chatty@xxxxxxx>
> >> ---
> >
> > The patch _looks_ good, but I have problems getting this to work on a
> > 3M2256. What devices were this one tested on so far?
>
> Hi Henrik,
>
> I tested it against 3M1968. I'll try to have it again to make more testing.
> What symptoms do you have?

I think it is the input mode setting, but I am not sure yet.

Thanks,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/