Re: linux-next: build warning after merge of the driver-core tree

From: Stephen Rothwell
Date: Thu Mar 17 2011 - 19:10:19 EST


Hi All,

On Mon, 21 Feb 2011 16:50:23 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, 21 Feb 2011 16:37:27 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > After merging the driver-core tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/rtc/rtc-m41t94.c: In function 'm41t94_remove':
> > drivers/rtc/rtc-m41t94.c:139: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
> > include/linux/platform_device.h:133: note: expected 'const struct platform_device *' but argument is of type 'struct spi_device *'
> >
> > Revealed by commit 71d642908d4e8e7a2a4a6e0490432e719ff466d5 ("Driver
> > core: convert platform_{get,set}_drvdata to static inline functions").
> > The warning is in code introduced by commit
> > 8fc2c767b06067b417c565c4e75731e68ed41fd8 ("rtc: add support for ST M41T94
> > SPI RTC").
>
> There are also:
>
> drivers/rtc/rtc-ds1390.c: In function 'ds1390_remove':
> drivers/rtc/rtc-ds1390.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
>
> Introduced in commit 06de18085122b873012cb23f043e2bdcf5f50923 ("rtc: add
> Dallas DS1390/93/94 RTC chips").
>
> drivers/rtc/rtc-ds3234.c: In function 'ds3234_remove':
> drivers/rtc/rtc-ds3234.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
>
> Introduced in commit 2f9b75e09ec3f62f2ebecec0ac9aec58656c2459 ("rtc: add
> device driver for Dallas DS3234 SPI RTC chip").

These are now in Linus' tree :-(

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature