Re: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)
From: Tony Luck
Date: Thu Mar 17 2011 - 18:48:20 EST
On Thu, Mar 17, 2011 at 3:42 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>> + memcpy(private->data, data, size);
>> + inode->i_size = private->size = size;
>>
>> inode->i_private = private;
>
> Better move that before d_add()
Will do.
> *blink*
> if (IS_ERR(root))
> return root;
> return root;
>
> ... or am I misreading the patch?
Your patch reading skills are fine ... the code deserves more than a *blink*.
Will fix.
-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/