Re: [PATCH 1/4] scatterlist: new helper functions

From: Maxim Levitsky
Date: Thu Mar 17 2011 - 09:17:53 EST


On Wed, 2011-03-16 at 23:41 -0700, Alex Dubov wrote:
> >
> > Do you believe that any other driver is likely to ue the
> > sg
> > infrastructure which this patch adds? Should those
> > additions be
> > internal to the memstick code, at least for now?
> >
>
> Considering the comments from Fujita and James, I suppose it will be best
> for now to fold the new sg functions into the memstick patch and
> investigate how the block layer functionality can be used to a greater
> utility at some later time.

I am thinking the same thing.
If the unusual sg code is a problem, I'll think of something later to
improve it, heck I can even completely rip it off and just use kernel
pointers, relying on block core to bounce for high-mem situations.
Since its a driver for a legacy hardware, mostly provided for
completeness, the performance difference shouldn't be much.


I think its ok to merge the code with folded sg code _for_ now, and then
I will send patches to address this point you didn't like.


OK?

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/