Re: [PATCH] scsi: use list_move() instead of list_del()/list_add()combination

From: Robert Love
Date: Wed Mar 16 2011 - 17:00:55 EST


On Tue, 2011-03-15 at 18:52 -0700, James Bottomley wrote:
> On Tue, 2011-03-15 at 16:57 -0700, Robert Love wrote:
> > From: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> > Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxx>
> > Cc: Robert Love <robert.w.love@xxxxxxxxx>
> > Cc: linux-scsi@xxxxxxxxxxxxxxx
> > Cc: devel@xxxxxxxxxxxxx
>
> You can junk the cc's; they're mostly annotations for git-send-email
>
> > Acked-by: Robert Love <robert.w.love@xxxxxxxxx>
>
> And this has to be Signed-off-by not Acked-by. The reason is that
> you've resent the patch (and altered it as you transmitted it) so that
> makes you part of the signoff chain. If you ack a patch, it means I can
> pick it up from source and you as maintainer didn't actually touch it.
>

Thanks for the clarification James.

Signed-off-by: Robert Love <robert.w.love@xxxxxxxxx>

Let me know if you, or anyone else, wants me to resend the patch with
the Signed-off line.

//Rob

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/