Re: Typo in linux-2.6.38/arch/x86/kernel/entry_32.S

From: Steven Rostedt
Date: Wed Mar 16 2011 - 16:22:44 EST


On Wed, 2011-03-16 at 21:09 +0100, Eric Vlette wrote:
> On 16/03/2011 20:52, Steven Rostedt wrote:
> > On Wed, Mar 16, 2011 at 02:15:26PM +0100, Eric Valette wrote:
> >> Hi,
> >>
> >> Trying to compile 2.6.38, I found the follwoing bug. Compiler barks...
> >
> > New compiler? (new binutils more likely)
>
> Maybe. I use debian unstable + experimental and upgrade packages almost
> everyday...

You probably have new binutils.

What does "as --version" give you. Binutils 2.21... ?

I think it was 2.21 that started giving problems.

>
> >>
> >> diff linux-2.6.38/arch/x86/kernel/entry_32.S
> >> linux-2.6.38/arch/x86/kernel/entry_32.S~
> >> 1416c1416
> >> < END(async_page_fault)
> >> ---
> >>> END(apf_page_fault)
>
> But obviously the begin end is not symmetric as in other function.

Right, there was a discussion before about this causing issues with new
binutils, and I think Ingo or Thomas said that they had patches to fix
these for x86. Which this looks like one.

The old binutils never complained.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/