Re: [PATCH 02/13] plat-spear: use list_move() instead of list_del()/list_add()combination

[viresh kumar]

On 03/16/2011 04:23 AM, Kirill A. Shutemov wrote:
> Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> ---
>  arch/arm/plat-spear/clock.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/plat-spear/clock.c b/arch/arm/plat-spear/clock.c
> index ee4f90e..1d24faf 100644
> --- a/arch/arm/plat-spear/clock.c
> +++ b/arch/arm/plat-spear/clock.c
> @@ -267,9 +267,7 @@ static void change_parent(struct clk *cclk, struct clk *pclk)
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&clocks_lock, flags);
> -	list_del(&cclk->sibling);
> -	list_add(&cclk->sibling, &pclk->children);
> -
> +	list_move(&cclk->sibling, &pclk->children);
>  	cclk->pclk = pclk;
>  	spin_unlock_irqrestore(&clocks_lock, flags);
>  }

Acked-by: Viresh Kumar <viresh.kumar@xxxxxx>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/