Re: [PATCH v2 12/12] driver: Google Memory Console

[H. Peter Anvin]

On 03/14/2011 01:03 PM, Mike Waychison wrote:
> On Sun, Mar 13, 2011 at 9:54 PM, H. Peter Anvin <hpa@xxxxxxxxxx> wrote:
>> On 03/11/2011 05:43 PM, Mike Waychison wrote:
>>> This patch introduces the 'memconsole' driver.
>>>
>>> Our firmware gives us access to an in-memory log of the firmware's
>>> output.   This gives us visibility in a data-center of headless machines
>>> as to what the firmware is doing.
>>>
>>> The memory console is found by the driver by finding a header block in
>>> the EBDA.  The buffer is then copied out, and is exported to userland in
>>> the file /sys/firmware/log.
>>>
>>
>> OK, I really don't like this.
>>
>> All it has is a 32-bit nonrandom signature, no DMI keying or anything
>> else to protect it.  This really isn't sufficient.
> 
> Good point.  I'll add some DMI strings checks.  It *should* be
> sufficient to just ensure that "Google, Inc." is the board vendor
> string (though I'll need to run some tests to verify that this covers
> the boards we care about).
> 

Sounds good.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/