Re: [PATCH 2/2] tracing - putting cond_resched into tace_pipe loop

[Steven Rostedt]

On Mon, 2011-03-14 at 16:07 +0100, Jiri Olsa wrote:
> So we get back the the while loop with no data added and with
> TRACE_TYPE_HANDLED return code, which will keep us in the loop.
> 
> Not sure this is bug or feature :)
> 
> 
Most bugs are features ;)

honestly, I'd love to rip out all the "bin", "hex" etc formats as they
are pretty much deprecated.

But as you pointed out that this can keep us in the inner loop, we need
to fix that. I prefer to fix it within the nop print function. Perhaps
we need to fill in something. "type: %d", iter->ent->type ?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/