Re: [RFC PATCH 3/4] PLATFORM: Introduce async platform_data attachapi

From: Andy Green
Date: Sun Mar 13 2011 - 14:13:31 EST


On 03/13/2011 05:48 PM, Somebody in the thread at some point said:
On Sun, Mar 13, 2011 at 05:13:31PM +0000, Andy Green wrote:
So when there's a bit more of Device Tree in evidence, are you going
to accept Device-tree based patches in usbnet etc along these lines,
or does that trigger the "do it in userspace" response, in which
case we are both wasting each others' time continuing to discuss
this at all?

As mentioned numerous times before, network naming stuff happens in
userspace, not in the kernel, so no matter what infrastructure is added,

The naming of that network interface happens in smsc95xx, in kernel: it uses a dodgy heuristic to choose between usb%d eth%d and others and gets it wrong in this case due to stuff outside its view. There's nothing golden and wonderful about that which needs protecting from outside hints.

insisting on naming the network device 'eth0' is not going to happen
within the kernel. Please use the tools we have today to do this with
no kernel changes.

As for other changes, it all depends on what you need to accomplish,
right? Those will be gladly reviewed on a case-by-case basis.

The immediate thing I would have liked to accomplish is to help smsc95xx make the right decision about naming and to use the MAC address in platform_data. It seemed this was a general issue though, so I generalized how it was done. But I don't have examples on my desk of boards with soldered-on USB other than smsc95xx Ethernet bridge.

At least, I am grateful we get down to brass tacks now and you clearly reject allowing the driver to take guidance to act more appropriately for its environment in the first place. Therefore, this won't get fixed by Device Tree either.

So, we don't need to discuss this any further: thanks again for your time.

-Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/