Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

From: Michael S. Tsirkin
Date: Sun Mar 13 2011 - 12:44:57 EST


On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote:
> Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit :
>
> > Other side is in drivers/net/tun.c and net/packet/af_packet.c
> > At least wrt tun it seems clear socket is not locked.
>
> Yes (assuming you refer to tun_net_xmit())
>
> > Besides queue, dequeue seems to be done without socket locked.
> >
>
> It seems this code (assuming you speak of drivers/vhost/net.c ?) has
> some races indeed.
>

Hmm. Any more besides the one fixed here?

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/