Re: [PATCH 0/2] jump label: update for .39

From: Ralf Baechle
Date: Thu Mar 10 2011 - 19:39:20 EST


On Thu, Mar 10, 2011 at 04:22:14PM -0500, Mathieu Desnoyers wrote:

> You seem to be contradicting yourself here. I'm concerned about having
> "structures" of a size not power of two. Can we simply either
>
> - Add a padding element at the end
> or
> - use .align 4*sizeof(long) at the beginning
>
> to make sure the linker won't put any holes when it puts objects
> together ?

It may only be a technicality but but careful with .align. On some
architectures .align x will align to a multiple of x; on other
architectures to 2^x. Another reason to stick to C wherever possible.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/