Re: [PATCH trace-cmd 3/3] Revert "trace-cmd: Use conditional assignmentof CC and AR"
From: Darren Hart
Date: Thu Mar 10 2011 - 01:34:46 EST
On 03/09/2011 06:51 PM, Steven Rostedt wrote:
On Wed, 2011-03-09 at 18:27 -0800, David Sharp wrote:
On Wed, Mar 9, 2011 at 5:58 PM, Darren Hart<dvhart@xxxxxxxxxxxxxxx> wrote:
dvhart@doubt:templates$ cat Makefile
ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
endif
all:
echo "CC: $(CC)"
dvhart@doubt:templates$ make -s
CC: cc
dvhart@doubt:templates$ CC=gcc-4.5.1 make -s
CC: gcc-4.5.1
dvhart@doubt:templates$ CROSS_COMPILE=my-cross- make -s
CC: my-cross-gcc
Seems to meet everyone's needs without changing any tools/scripts/etc that
have used trace-cmd before or after the CC ?= wreckage.
It's a little odd that the default CC is "cc" unless you supply
CROSS_COMPILE, then it's "gcc". I'd probably be okay with this, but I
would think it's weird.
I don't know the answers, but if we take the kernel Makefile as a
template, then setting CC doesn't work.
I really don't care much for this either. But I'm trying to make it work
for everyone. Honestly, I think the BUILD_CC version is the cleanest,
but I understand that this will add a burden onto Darren to fix his
tools to handle it, whereas, I would like to avoid that.
This is a very minor issue and will take me less time to fix than
another half-dozen emails arguing for a different solution :-) However,
being able to specify CC on the command line _is_ a very common thing,
and preventing it from working will likely cause this to come up again
in the future.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/