Re: [PATCH] add missing guest clock update removed bye48672fa25e879f7ae21785c7efd187738139593

[Nikola Ciprich]

> Can you try moving the kvm_make_request() inside the if conditional and  
> see if it that also fixes it?

yes, changing to:
if (unlikely(vcpu->cpu != cpu) || check_tsc_unstable()) {
	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
	/* Make sure TSC doesn't go backwards */
	s64 tsc_delta = !vcpu->arch.last_host_tsc ? 0 :

is also OK.

what about changing:
if (check_tsc_unstable()) {
	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);                                                                                                               
	vcpu->arch.tsc_catchup = 1;
	kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);
}                                                                                                                                                                       

to:

if (check_tsc_unstable()) {
	kvm_x86_ops->adjust_tsc_offset(vcpu, -tsc_delta);                                                                                                               
	vcpu->arch.tsc_catchup = 1;
}                                                                                                                                                                       
kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu);

this fixes thinks for me as well..
n.
?


> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@xxxxxxxxxxx
-------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/